Re: [INTERNALS-WIN] Advice for enhancing ext/standard/proc_open.c (Windows CLI only)

hi,

What's the goal of this patch exactly? Avoid the creation of the console window?

However the patch looks wrong. It kills the bypass shell option, which
is not something we like to do.

Cheers,

On Sat, Aug 21, 2010 at 7:24 AM, NoteWorthy Online
<[email protected]> wrote:
> Hello,
>
> I am in the process of testing a php 5.3 patch to proc_open.c that deals
> strictly with the Windows implementation of proc_open called from a PHP CLI
> script. I am trying to eliminate unnecessary console windows when proc_open
> is called from a CLI script that provides handles for stdin, stdout, and
> stderr. All of the code in my patch is contained in PHP_WIN32 sections, so
> it has no actual impact on other builds. A summary explanation page can be
> found on github here:
>
> http://github.com/nwsw/nwc2utsk/wiki/Patching-proc_open-to-support-DETACHED_PROCESS
>
>
> I welcome any advice on how to proceed. For example, is this the correct PHP
> internals list for introducing this?
>
> Regards,
>
> Eric,
> http://noteworthysoftware.com
>
>
> --
> Windows Internals Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org