[PHP-DEV] Re: [PHP-DEV] [RFC] [DISCUSSION] ext/gd 2.4 — code c sync, Gd\* OOP API, 2D vector/canvas
[email protected] (Pierre Joye) Mon, 20 Jul 2026 16:36:18 +0700
| Newsgroups | php.internals |
|---|---|
| Message-ID | <CAEZPtU6siS8ybR3tf_LTdTLMRtZqivtJr5MCfa6Jt8AOMSW_CQ@mail.gmail.com> |
Hi Tim, On Sun, Jul 19, 2026 at 8:35 PM Tim Düsterhus <[email protected]> wrote: > 2. The proposed exceptions are in violation of the Throwable policy that > you can find at: > https://github.com/php/policies/blob/main/coding-standards-and-naming.rst#throwables. > In particular you need a “GdException extends \Exception” base > exception, and must never inherit from RuntimeException. fixed, it now has a base Gd\GdException. All other new exceptions extend it. > 3. The stub for Gd\Image contains another class Image declaration. Fixed Cheers, -- Pierre @pierrejoye