Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.6
[email protected] ("Sjoerd Langkemper") Wed, 29 Jul 2026 12:02:15 +0200
| Newsgroups | php.internals |
|---|---|
| Message-ID | <[email protected]> |
--6f82c0195487e569299edfe9f2c59641cfad0c29 Content-Type: text/plain Content-Transfer-Encoding: 7bit Hi, Seeing this discussion during the voting phase makes me think the discussion phase wasn't properly completed yet, and I did a poor job in merging all opinions into a RFC proposal. I would rather not fuel the discussion any further, but I would prefer to let the voting play out. Jakub Zelenka wrote: > The problem is that there wasn't enough time I don't know your situation, but it seems you have quite a lot of work on your plate. Is there something I or anyone can do to reduce your load? > This is exactly a half baked deprecation because ... this does not give us any code removal and we still need to maintain it. This is true, but my goal was to prevent abuse of the dechunk filter in filter chain attacks, not to reduce maintainance load. See also my PR to make filter chain attacks more difficult: https://github.com/php/php-src/pull/22110 > to properly investigate if the things can be improved on the C side. I tried some solutions, the most promising here: https://github.com/php/php-src/pull/22548 > There was just some bug and then immediate proposal to deprecate it without first not even realising that it's used by chunked encdoing which I needed to point out. For reference, this was in https://github.com/php/php-src/pull/22036, and there is some more information in https://github.com/php/php-src/issues/21983. Regards, Sjoerd Langkemper --6f82c0195487e569299edfe9f2c59641cfad0c29 Content-Type: text/html Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><title></title></head><body><div>Hi,</div><di= v><br></div><div>Seeing this discussion during the voting phase makes me= think the discussion phase wasn't properly completed yet, and I did a p= oor job in merging all opinions into a RFC proposal. I would rather not = fuel the discussion any further, but I would prefer to let the voting pl= ay out.</div><div><br></div><div>Jakub Zelenka wrote:</div><div><br></di= v><blockquote type=3D"cite" id=3D"qt" style=3D""><div dir=3D"ltr"><div c= lass=3D"qt-gmail_quote qt-gmail_quote_container"><div>The problem is tha= t there wasn't enough time</div></div></div></blockquote><div><br></div>= <div>I don't know your situation, but it seems you have quite a lot of w= ork on your plate. Is there something I or anyone can do to reduce your = load?</div><div><br></div><blockquote type=3D"cite" id=3D"qt" style=3D""= ><div><div class=3D"qt-gmail_quote qt-gmail_quote_container"><div dir=3D= "auto">This is exactly a half baked deprecation because ... this does no= t give us any code removal and we still need to maintain it.</div></div>= </div></blockquote><div><br></div><div>This is true, but my goal was to = prevent abuse of the dechunk filter in filter chain attacks, not to redu= ce maintainance load. See also my PR to make filter chain attacks more d= ifficult: <a href=3D"https://github.com/php/php-src/pull/22110">htt= ps://github.com/php/php-src/pull/22110</a> </div><div><br></div><bl= ockquote type=3D"cite" id=3D"qt" style=3D""><div dir=3D"ltr"><div class=3D= "qt-gmail_quote qt-gmail_quote_container"><div>to properly investigate i= f the things can be improved on the C side. <br></div></div></div></bloc= kquote><div><br></div><div>I tried some solutions, the most promising he= re: <a href=3D"https://github.com/php/php-src/pull/22548">https://g= ithub.com/php/php-src/pull/22548</a><br></div><div><br></div><blockquote= type=3D"cite" id=3D"qt" style=3D""><div dir=3D"ltr"><div class=3D"qt-gm= ail_quote qt-gmail_quote_container"><div>There was just some bug and the= n immediate proposal to deprecate it without first not even realising th= at it's used by chunked encdoing which I needed to point out.<br></div><= /div></div></blockquote><div><br></div><div>For reference, this was in&n= bsp;<a href=3D"https://github.com/php/php-src/pull/22036">https://github= .com/php/php-src/pull/22036</a>, and there is some more information in&n= bsp;<a href=3D"https://github.com/php/php-src/issues/21983">https://gith= ub.com/php/php-src/issues/21983</a>.</div><div><br></div><div>Regards,</= div><div><br></div><div>Sjoerd Langkemper</div></body></html> --6f82c0195487e569299edfe9f2c59641cfad0c29--