Re: [PHP-DEV] [RFC] IntlRelativeDateTimeFormatter

[email protected] (David CARLIER)
Newsgroups php.internals
Message-ID <CA+XhMqwtOgk8TahP+L=95e6+=FOYdFQYbTH73GoKUPLiu2mdvw@mail.gmail.com>
Here my two cents,

- I would be in favor of an enum instead for the constants.
- I would be in favor of an appropriate namespace to avoid conflicts.
- It seems there are missing parts, e.g. how do you plan (or do you
plan to) express the 2nd argument of ureldateformat_open().

There is probably more to it, just surface level first impressions.

Cheers.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.