Re: [PHP-DEV] Fwd: date extension broken tests
[email protected] (Tjerk Meesters)
| Newsgroups | php.internals |
|---|---|
| Message-ID | <[email protected]> |
Hi! On 25 Aug, 2014, at 5:43 pm, Dmitry Stogov <[email protected]> wrote: > Hi Derick, > > Could you please take a look into these tests failures. > I actually, think that the new behavior is right. > Calls to parent::__constructor() shouldn't change value of already > constructed $this. I think the following commit is relevant to the discussion: http://git.php.net/?p=php-src.git;a=commit;h=c749fe2067d29615df250e59c9a891a63dcc7e7f I’ve also added that to the discussion on the #67118 itself: https://bugs.php.net/bug.php?id=67118#1408926078 > > The expectation of ext/data/tests/bug67118_2.phpt looks completely wrong. > > The actual output of ext/data/tests/bug67118.phpt seems right. I was going to look at those test cases this week, but I’m glad this is now in more than capable hands :) > > I'm going to change expectation of these tests in master if you don't > object. > > Thanks. Dmitry. > > > ---------- Forwarded message ---------- > From: Dmitry Stogov <[email protected]> > Date: Mon, Aug 25, 2014 at 1:28 PM > Subject: Re: date extension broken tests > To: Lior Kaplan <[email protected]> > Cc: Anatol Belski <[email protected]> > > > Hi Lior, > > This is known phpng related problem described here > https://wiki.php.net/phpng#known_problems > > Thanks. Dmitry. > > > On Mon, Aug 25, 2014 at 1:09 PM, Lior Kaplan <[email protected]> wrote: > >> Hi Anatol, >> >> It seems you've done some changes to the date extension recently, could >> you take a look at these two failures. >> >> Dmitry - FYI in case it's phpng related. >> >> Bug #67118 crashes in DateTime when this used after failed __construct [ext/date/tests/bug67118.phpt] >> >> Regression introduce in fix for Bug #67118 - Invalid code [ext/date/tests/bug67118_2.phpt] >> >> >> Kaplan >>