Re: [PHP-DEV] Remove generated VM from git?
[email protected] (Andrea Faulds)
| Newsgroups | php.internals |
|---|---|
| Message-ID | <[email protected]> |
On 26 Aug 2014, at 22:17, Stas Malyshev <[email protected]> wrote: > That's not an advantage. Having extra file in git is no problem at all, > we don't pay per byte, and somebody who can't handle regenerating the VM > file should not be messing with the VM (for one, they would notice the > problem immediately on running the test for the change locally, and if > they don't test the changes locally we probably don't want these > changes). And it's not like we change the VM every day. Actually, I wouldn’t be so bothered by this if I didn’t have to manually regenerate the VM. Would it be possible to make `make` track Zend/zend_vm_def.h? -- Andrea Faulds http://ajf.me/