Re: [PHP-DEV] Re: zpp and zend_string
[email protected] (Andrea Faulds)
| Newsgroups | php.internals |
|---|---|
| Message-ID | <[email protected]> |
On 27 Aug 2014, at 06:34, Tjerk Meesters <[email protected]> wrote: > With the recent merge of int64 the `zend_string` type now uses `size_t` to store its length, but ZPP (and friends) still use `int *` to store the parsed string lengths. > > http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_API.c#519 > > This look like an oversight. Will this be fixed as well? While we’re at it, why does zpp take an int* for param_count when you use *? The type of param_count in zend_fcall_info is uint32_t (formerly zend_uint), and if you’re using *, that’s the struct member you’ll be giving zpp a pointer to. -- Andrea Faulds http://ajf.me/