Re: [PHP-DEV] destructors and output_buffering

Hi,

One line fix, nice :)

A quick question about how resources are freed :
if some variables are computed inside a singleton and read through a 
myclass::instance()->get_my_variable(), should we expect to have those 
variables available when calling ob_start() callbacks ?

 From experiment, they are still available, but since 
zend_call_destructors is called before ob_start(), I wonder if this is a 
safe behaviour.

Thanks,
   Jocelyn



Le 02/09/2014 09:56, Stas Malyshev a écrit :
> Hi!
>
> I've created a proposed fix for #67644:
>
> https://github.com/php/php-src/pull/798
>
> It is the most conservative one which I'm thinking of putting into 5.4,
> so that at least we won't have segfaults. If we want to improve upon it,
> we can do that in 5.5/5.6, but I'd like at least plug the segfaults in
> 5.4 for now.
>
> Any objections to this or better proposals?
>