Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/ext/pdo/pdo_dbh.c branches/PHP_5_3/ext/pdo/php_pdo_driver.h branches/PHP_5_3/ext/pdo_pgsql/pdo_pgsql.c branches/PHP_5_3/ext/pdo_pgsql/pgsql_driver.c branches/PHP_5_3/ext/pdo_pgsq

--00c09fa2176f50851a04890faa34
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

I'll adjust the code to simply use in_txn flag for the moment to avoid the
structure change.

2010/6/14 Johannes Schl=FCter <[email protected]>

> On Thu, 2010-06-10 at 12:11 +0000, Ilia Alshanetsky wrote:
> > Modified: php/php-src/branches/PHP_5_3/ext/pdo/php_pdo_driver.h
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > ---
> > php/php-src/branches/PHP_5_3/ext/pdo/php_pdo_driver.h       2010-06-10
> > 11:45:51 UTC (rev 300350)
> > +++
> > php/php-src/branches/PHP_5_3/ext/pdo/php_pdo_driver.h       2010-06-10
> > 12:11:19 UTC (rev 300351)
> > @@ -310,6 +310,7 @@
> >         pdo_dbh_check_liveness_func     check_liveness;
> >         pdo_dbh_get_driver_methods_func get_driver_methods;
> >         pdo_dbh_request_shutdown        persistent_shutdown;
> > +       pdo_dbh_txn_func                in_transaction;
> >  };
> >
> >  /* }}} */
>
> Here you are changing a structure which is allocated and initialized in
> a driver and then read from the PDO core. PDO core will therefore read
> invalid memory when a driver compiled against 5.3.2 is used in 5.3.3
> while we usually guarantee binary compatibility in bug fix releases.
>
> This for instance affects distributors or MSFT's sqlsrv driver.
>
> johannes
>
>
>
>

--00c09fa2176f50851a04890faa34--