[PEAR-BUG] Bug #19049 [Fbk->WFx]: remove error_reporting (for PEAR QA team)

Edit report at https://pear.php.net/bugs/bug.php?id=19049&edit=1

 ID:               19049
 Updated by:       [email protected]
 Reported By:      danielc at analysisandsolutions dot com
 Summary:          remove error_reporting (for PEAR QA team)
-Status:           Feedback
+Status:           Wont fix
 Type:             Bug
 Package:          OpenID
 Package Version:  SVN
 PHP Version:      5.4.0alpha1
 Roadmap Versions: 
 New Comment:

-Status: Feedback
+Status: Wont fix
We will do so when Cache_Lite is E_STRICT compliant.


Previous Comments:
------------------------------------------------------------------------

[2012-10-16 15:12:21] danielc

Yes, there are E_STRICT issues.  To prevent seeing them, set the error
reporting level when executing the test suite.  Examples of how to do so
are provided in this bug's initial description.

------------------------------------------------------------------------

[2012-10-14 18:24:59] till

-Status: Open
+Status: Feedback
Hey guys,

the patch is incomplete:

1) OpenID_Store_CacheLiteTest::testAssociations
Non-static method PEAR::raiseError() should not be called statically,
assuming $this 
from incompatible context

/Users/till/Documents/pear/share/pear/Cache/Lite.php:549
/Users/till/Documents/pear/share/pear/Cache/Lite.php:590
/Users/till/Documents/pear/share/pear/Cache/Lite.php:440
/Users/till/Documents/workspaces/pear-
forks/openid/OpenID/Store/CacheLite.php:296
/Users/till/Documents/workspaces/pear-
forks/openid/OpenID/Store/CacheLite.php:136
/Users/till/Documents/workspaces/pear-
forks/openid/tests/OpenID/Store/CacheLiteTest.php:94

2) OpenID_Store_CacheLiteTest::testDiscover
Non-static method PEAR::raiseError() should not be called statically,
assuming $this 
from incompatible context

/Users/till/Documents/pear/share/pear/Cache/Lite.php:549
/Users/till/Documents/pear/share/pear/Cache/Lite.php:590
/Users/till/Documents/pear/share/pear/Cache/Lite.php:440
/Users/till/Documents/workspaces/pear-
forks/openid/OpenID/Store/CacheLite.php:296
/Users/till/Documents/workspaces/pear-
forks/openid/OpenID/Store/CacheLite.php:188
/Users/till/Documents/workspaces/pear-
forks/openid/tests/OpenID/Store/CacheLiteTest.php:115

3) OpenID_Store_CacheLiteTest::testNonce
Non-static method PEAR::raiseError() should not be called statically,
assuming $this 
from incompatible context

/Users/till/Documents/pear/share/pear/Cache/Lite.php:549
/Users/till/Documents/pear/share/pear/Cache/Lite.php:590
/Users/till/Documents/pear/share/pear/Cache/Lite.php:440
/Users/till/Documents/workspaces/pear-
forks/openid/OpenID/Store/CacheLite.php:296
/Users/till/Documents/workspaces/pear-
forks/openid/OpenID/Store/CacheLite.php:246
/Users/till/Documents/workspaces/pear-
forks/openid/tests/OpenID/Store/CacheLiteTest.php:135


So whenever the patch is applied, these three tests fail due to E_STRICT
goodness in 
PEAR. So either fix this in Cache_Lite first or let the error_reporting
be.

------------------------------------------------------------------------

[2011-11-16 03:58:25] danielc

Added #patch bug:19049;patch:qa;revision:1321415905;.

------------------------------------------------------------------------

[2011-11-16 03:58:13] danielc

Description:
------------
Hi:

The PEAR Quality Assurance team is working to get all unit tests passing
in all PEAR packages.  We will then collaborate with the PHP QA team to
get PEAR's unit tests onto PHP's Continuous Integration server, which
will be running the latest versions of PHP 5.3, 5.4 and trunk.  The goal
is to improve PHP's stability and quality.  Your help is needed,
please.

In a moment I will attach a patch removing error_reporting settings from
your package.  Please apply this patch as soon as possible.

These changes are necessary for several reasons, some of which include:
* What is contained in E_ALL shifts over time.
* Some test runs need to suppress deprecated behaviors.
* Some test runs seek deprecated and or strict errors.

Error reporting levels should be set when executing the test suite. 
Here are examples:

PEAR RUN-TEST:
cd /path/to/package
pear run-tests -i "-d error_reporting=22527" -r tests

PHPUNIT:
cd /path/to/package
phpunit -d error_reporting=22527 tests/AllTests

PHP RUN-TESTS:
cd /path/to/package
php /path/to/run-tests.php -d error_reporting=22527 tests

Thank you for making PEAR and PHP better,

--Dan

------------------------------------------------------------------------


-- 
Edit this bug report at https://pear.php.net/bugs/bug.php?id=19049&edit=1