Edit report at http://pear.php.net/bugs/bug.php?id=17620&edit=1
ID: 17620
Updated by: [email protected]
Reported By: dirkthomas at tigris dot org
Summary: Trimming newlines should not be done by the engines
Status: Open
Type: Feature/Change Request
Package: Text_Diff
Operating System: Windows 7
Package Version: 1.1.1
PHP Version: 5.3.2
Roadmap Versions:
New Comment:
This patch breaks the string.phpt unit test. And please add tests for
this new feature.
Also, please consider using Horde_Text_Diff from pear.horde.org, which
is the PHP5 successor of Text_Diff. I wouldn't mind patches for both
versions though.
Previous Comments:
------------------------------------------------------------------------
[2011-04-29 19:24:13] dirkthomas_tigrisorg
Added #patch
bug:17620;patch:adding-optional-keep-newlines-parameter;revision:1304105053;.
------------------------------------------------------------------------
[2010-07-22 08:52:29] dirkthomas_tigrisorg
Description:
------------
If you want to use the package to diff two different files it should be
possible to detect differences in line endings too. This is currently
not possible since every engine processes the passed line with
"trimNewlines". Therefore this should be moved out of the engines are at
least be made configurable.
Since i am a developer of WebSVN (http://www.websvn.info) i currently
have to patch the package to remove the trimming, since it is perfectly
valid to have lines which only differ in line endings, but which needs
to be detected as a difference.
------------------------------------------------------------------------
--
Edit this bug report at http://pear.php.net/bugs/bug.php?id=17620&edit=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not
affiliated with the servers or forums shown here and is not responsible for
the content of articles, which is written by their respective authors.