[PEAR-BUG] Doc #18196 [Com]: PEAR MultiLineCondition.SpaceBeforeOpenBrace not consistent with newline chars

[email protected] ("[email protected]")
Newsgroups php.pear.bugs
Message-ID <[email protected]>
Edit report at http://pear.php.net/bugs/bug.php?id=18196&edit=1

 ID:               18196
 Comment by:       [email protected]
 Reported By:      spam at endstadium dot com
 Summary:          PEAR MultiLineCondition.SpaceBeforeOpenBrace not
                    consistent with newline chars
 Status:           Closed
 Type:             Documentation Problem
 Package:          PHP_CodeSniffer
 Package Version:  1.3.0RC1
 PHP Version:      5.3.1
 Assigned To:      squiz
 Roadmap Versions: 
 New Comment:

Sorry, it seems that it was my filesystem issue. Bug is not there
anymore.


Previous Comments:
------------------------------------------------------------------------

[2011-07-07 10:25:18] arzala

I have found that this bug has reappeared in latest stable version.
Today I installed 1.3.0 stable and ran PEAR coding standard for code
mentioned in this report and found same error.

------------------------------------------------------------------------

[2011-01-19 23:30:23] squiz

-Status: Feedback
+Status: Closed
This bug has been fixed in SVN.

If this was a documentation problem, the fix will appear on pear.php.net
by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should
be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.

------------------------------------------------------------------------

[2011-01-19 23:28:16] squiz

-Summary: PEAR SpaceBeforeOpenBrace is not consistent with
          different newline chars
+Summary: PEAR MultiLineCondition.SpaceBeforeOpenBrace not
          consistent with newline chars


------------------------------------------------------------------------

[2011-01-19 23:27:18] squiz

-Summary:
          PEAR.ControlStructures.MultiLineCondition.SpaceBeforeOpenBrace
          - dont get it..
+Summary: PEAR SpaceBeforeOpenBrace is not consistent with
          different newline chars


------------------------------------------------------------------------

[2011-01-19 23:26:40] squiz

PHP_CodeSniffer handles DOS newlines just fine. The sniff itself didn't
have newline detection in it for this particular message, so the error
message only appeared (in this case) when the newline was two chars long
(like /r/n).

I've changed the sniff to detect that there is a newline after the brace
and present an error message that says this. This works for all newline
chars phpcs detects (/n, /r, /r/n).

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
    http://pear.php.net/bugs/bug.php?id=18196

-- 
Edit this bug report at http://pear.php.net/bugs/bug.php?id=18196&edit=1
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.