[PEAR-BUG] Bug #18228 [Fbk->Csd]: Improved string literals handling

Edit report at http://pear.php.net/bugs/bug.php?id=18228&edit=1

 ID:               18228
 Updated by:       [email protected]
 Reported By:      alec at alec dot pl
 Summary:          Improved string literals handling
-Status:           Feedback
+Status:           Closed
 Type:             Bug
 Package:          Net_Sieve
 Package Version:  SVN
 PHP Version:      Irrelevant
-Assigned To:      
+Assigned To:      yunosh
 Roadmap Versions: 
 New Comment:

-Status:      Feedback
+Status:      Closed
-Assigned To:
+Assigned To: yunosh
Thank you for your bug report. This issue has been fixed
in the latest released version of the package, which you can download at
http://pear.php.net/get/

Turned out, this was a problem with PHPUnit not working correctly with
PEAR_Errors.


Previous Comments:
------------------------------------------------------------------------

[2011-02-13 09:20:59] alec

Works for me. I don't see a bug in the code. Debug log would be helpful.
However we should add error checking on $this->_sock->read() result in
_recvBytes().

------------------------------------------------------------------------

[2011-02-12 19:19:58] yunosh

With that patch, the code runs amok if authentication fails. Looks like
an infinite loop, but I haven't tracked it down so far.

------------------------------------------------------------------------

[2011-02-11 15:52:45] alec

Example script for 1st regexp issue:

if false header :contains "Subject" "test" {
    vacation :text
reply {123}
.
;
}

------------------------------------------------------------------------

[2011-02-11 15:47:29] alec

The main change is necessary and it's explained in initial comment.
There are also 3 expressions modified:
1. Regexp in _cmdGetScript():
'/^{[0-9]+}\r\n/' replaced by '/^{[0-9]+}\r\n/'
Reason: {xx} here is always alone in the line. It should be faster this
way. Also consider a script with "# {12}" text inside.

2. Regexp in _doCmd():
'/^{([0-9]+)\+?}/i' replaced by '/^{([0-9]+)}/i'
Reason: This is for parsing server response. RFC5804 says that server
responses uses only literal-s2c form which allows only numbers inside
brackets (no "+" character here).
BTW: /i also is not needed here, and should be removed.

------------------------------------------------------------------------

[2011-02-11 15:16:40] yunosh

-Status: Open
+Status: Feedback
Can you please create separate patches for those and explain why exactly
you think they are necessary?

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
    http://pear.php.net/bugs/bug.php?id=18228

-- 
Edit this bug report at http://pear.php.net/bugs/bug.php?id=18228&edit=1