svn: /pear2/BugManager/trunk/src/BugManager/Site/PEAR/ IssueManager.php

[email protected] (Greg Beaver) Sat, 11 Sep 2010 18:22:17 +0000
Newsgroups php.pear.cvs,php.pear.core
Message-ID <[email protected]>
cellog                                   Sat, 11 Sep 2010 18:22:17 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=303279

Log:
add SVN and I have no idea as valid package versions

Changed paths:
    U   pear2/BugManager/trunk/src/BugManager/Site/PEAR/IssueManager.php

Modified: pear2/BugManager/trunk/src/BugManager/Site/PEAR/IssueManager.php
===================================================================
--- pear2/BugManager/trunk/src/BugManager/Site/PEAR/IssueManager.php	2010-09-11 15:29:42 UTC (rev 303278)
+++ pear2/BugManager/trunk/src/BugManager/Site/PEAR/IssueManager.php	2010-09-11 18:22:17 UTC (rev 303279)
@@ -223,19 +223,10 @@
             $sql = 'SELECT COUNT(*) as count FROM packages WHERE name="' .
                 $this->esc($value) . '"';
         } elseif ($contextname == 'packageversion') {
-            Issue::addEscaper($this->escaper);
-            // first determine if there are any releases at all
-            $sql = 'SELECT COUNT(*) as count FROM packages p, releases r
-                WHERE p.name=' . $bug->context['packagename']->value() . ' AND
-                    r.package=p.id';
-            $result = $this->mysqli->query($sql);
-            if ($result === false) {
-                throw new BugManager\UnexpectedValueException('Database error: '.$this->mysqli->error);
+            if ($value == "SVN" || $value == "I have no idea") {
+                return true;
             }
-            $ret = $result->fetch_assoc();
-            if (!$ret['count']) {
-                return $value === null || $value === "";
-            }
+            Issue::addEscaper($this->escaper);

             $sql = 'SELECT COUNT(*) as count FROM packages p, releases r
                 WHERE p.name=' . $bug->context['packagename']->value() . ' AND
@@ -292,6 +283,10 @@
                 $ret[] = $res['val'];
             }
         }
+        if ($contextname == 'packageversion') {
+            $ret[] = "SVN";
+            $ret[] = "I have no idea";
+        }
         return $ret;
     }
 }