Re: [PEAR-DEV] Hosting PEAR's git repositories on git.php.net
[email protected] (Christian Weiske)
| Newsgroups | php.pear.dev |
|---|---|
| Message-ID | <20120829131513.1d466645@cyberdyne> |
Hi Till, > > - Github is an entity we do not have any control over. > > Their Terms of Services[1] state that they can delete and repository > > and user/organization at their will, without any notice or a way to > > get the code back. > I don't believe this is going to happen. While it is unlikely, it is possible. > Besides, what keeps us from mirroring our Github organizations > somewhere else? I have the deep that simply mirroring repositories can be dangerous if someone force-pushes an empty repository on the original repository, and this one gets mirrored then. > > - We would get back proper commit mails with diffs > I am not sure if I see more email I don't have time to read as an > advantage. I prefer the interface a lot. You don't read them, but other people do. We had numerous occasions where bugs we spotted by people reading the commit diff mails. > > The only downside I see is that merging pull requests isn't a one > > click action anymore, since the github repository is only a mirror, > > and no commits may be made to it directly. > > This feature has lots of implications. It's not just the maintainers > who have to figure out four git commands to merge a PR vs one click, > for me it's also the code review which comes with the PR on github, > fast servers etc.. Code review is still possible on github. Just the merge action takes place on your CLI compared to the github button. > Also, for a PR to "happen", the contributors will have to know how to > send one as well. Still possible via github. > Or well, I don't see a reason to make contributing and maintaining > more painful than it really has to be. The "only" maintainer burden would be more effort to merge pull requests. We could provide a git command that makes this easy, e.g. $ git merge-pull http://github.com/pear/Net_Foo/pull/1 > Otherwise, I am against moving it all to php.net at this point. I > more prefer things where they are. Administration of the github organizations and repositories is a PITA, that's one of the things I absolutely don't like "as they are". -- Regards/Mit freundlichen Grüßen Christian Weiske -= Geeking around in the name of science since 1982 =-