Re: [PEAR-DEV] Re: [PEPr] -1 for RFC::Uploadcare

till wrote:
> On Monday, December 17, 2012 at 10:35 PM, Lester Caine wrote:
>> Till Klampaeckel wrote:
>>> I gave you feedback earlier, none of it was implemented.
>>
>>
>>
>> I'm with you Gray Hound ... using spaces in PEAR files when the core PHP
>> standard is to use tabs is just insane. NOW I know why I've been having problems
>> since my entire code base has always used tabs indenting and I don't intend to
>> change any time soon ...
>> My historic PEAR libraries are all tabbed files but I don't know where they
>> originated. It's the new stuff which is now using spaces?
>
> No, I think PEAR has always been using spaces. Regardless — there's a lot more besides spaces in this proposal. Class prefix, tests, etc..
>
> For coding style related we have a tool called PHP_CodeSniffer:
>
> $ [sudo] pear install PHP_CodeSniffer
> $ phpcs /path/to/your/code/*

That fails to work here ... but I don't have time to find out why - AH pear 
install is seeing the SUSE defaults not the PHP5.4 install default! Don't you 
just love 'standards' :)

MY 2008 package of PEAR is tabbed, so perhaps that was done by someone else to 
make it compatible with core standards. It does explain why I had problems with 
fixing the e_strict stuff. I'd simply missed that the editor was replacing the 
white space so then syncing with the PEAR code base messed up - so I have two 
versions of the code base :(

Stripping white space before outputting html/css/javascript etc is the ideal, 
but tabs are the next best divider and certainly make a lot more sense when 
using templating to REDUCE the number of characters which may need to be 
transmitted. SO I have no plans to switch coding standard for just one file 
format (and library since ADOdb library is tabbed) especially when those files 
may well have content for building other file formats. And my Eclipse IDE is 
configured to use tabs for all file formats, so I will not be using CodeSniffer 
any time soon! ;)

I'm beginning to understand why there is a difference between what we have been 
using for years and what is NOW being proposed as the coding standard for PHP 
which IS at odds with the coding standards defined in php.net and shipped with 
every PHP install?

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk