Re: [PEAR-DEV] Developing PEAR::Auth

Armin, I've commented on your PRs on GitHub.

Main thing is create a PR for a feature not a file. All the printHTMLOutput
code changes should be in a single PR not spread across 3.

Also as it stands, I wouldn't merge those patches as is. See more detail
https://github.com/pear/Auth/pull/1

Adam Ashley

On Tue, Jan 8, 2013 at 12:25 AM, till <[email protected]> wrote:

> Hi Armin,
>
> I am not a 100% sure.
>
> The packages you are interested in are hosted here:
>
> https://github.com/pear/Auth
> https://github.com/pear/DB *
> https://github.com/pear/Mail
> https://github.com/pear/Mail_Queue *
>
> You can obtain a copy by "cloning" and/or forking the repository.
>
> A pull request is a process where you send a patch from your clone/fork to
> the upstream. :)
>
> Thus far no special privileges are required to do this!
>
> A guide to Git(hub) is here:
> https://help.github.com/articles/set-up-git
>
>
> To explain *:
>
> 1) DB is deprecated and people should use MDB2
> https://github.com/pear/MDB2
>
> 2) Mail_Queue will be deprecated later in Q1/2013
>
> I have been working on Mail_Queue2: https://github.com/pear2/Mail_Queue
>
> ---
> Deprecation means that we'd like to have people focus their efforts on the
> newer maintained code. :-)
>
> To get into any package development, it's best to find issues to work on
> and address them. E.g. — fix bugs, add new features.
>
> Does that help?
>
> Till
>
> On Monday, January 7, 2013 at 5:18 PM, Armin Bidlingmaier wrote:
>
> > Hi Till,
> >
> > no sorry, i´m not familiar with git.
> > Is there a documentation about installing and using git with pear?
> >
> > Regards
> > Armin
> > > -------- Original-Nachricht --------
> > > Datum: Mon, 7 Jan 2013 16:57:08 +0100
> > > Von: till <[email protected] (mailto:[email protected])>
> > > An: Armin Bidlingmaier <[email protected] (mailto:[email protected])>
> > > CC: [email protected] (mailto:[email protected])
> > > Betreff: Re: [PEAR-DEV] Developing PEAR::Auth
> > >
> > >
> > >
> > > On Monday, January 7, 2013 at 4:18 PM, Armin Bidlingmaier wrote:
> > >
> > > > Hi Till,
> > > >
> > > > how can i send a pull-request?
> > > > Must i have an pear-account to do this?
> > >
> > >
> > > No — all code should be in git.
> > >
> > > Are you familiar with git?
> > >
> > > Till
> > > >
> > > > At the PEAR-Page its written, that i have to ask via email before i
> register a PEAR-Account.
> > > >
> > > > Regards
> > > > Armin
> > > > > -------- Original-Nachricht --------
> > > > > Datum: Mon, 7 Jan 2013 14:34:14 +0100
> > > > > Von: till <[email protected] (mailto:[email protected])>
> > > > > An: Armin Bidlingmaier <[email protected] (mailto:[email protected])>
> > > > > CC: [email protected] (mailto:[email protected])
> > > > > Betreff: Re: [PEAR-DEV] Developing PEAR::Auth
> > > > >
> > > > >
> > > > >
> > > > > On Monday, January 7, 2013 at 1:10 PM, Armin Bidlingmaier wrote:
> > > > >
> > > > > > Hi,
> > > > > >
> > > > > > i am a PHP-Developer and using several PEAR-Functions in my
> webpages,
> > > > > > basically PEAR::Auth, PEAR::DB, PEAR::Mail and PEAR::MailQueue.
> > > > > >
> > > > > > Now i´ve updates these Scripts on my own server to support UTF-8
> encoding
> > > > > > and several more options.
> > > > > >
> > > > > > How can help developing these classes?
> > > > > You can always start off by sending pull-requests to address bugs
> or features. That's the easiest way to get into it.
> > > > >
> > > > > If you have any questions, just let us know — a bunch of us are on
> IRC (efnet): #pear
> > > > >
> > > > > Till
>
>
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>