Re: [PEPr] Comment on Authentication::JWT

Thanks Christian! It's wonderful to bump into you again as well :)

Great suggestions, as always. I'll make the fixes and then resubmit for
further review.

Cheers,
-Anant


On Thu, Jan 17, 2013 at 9:14 PM, Christian Weiske <[email protected]> wrote:

> Hi Anant. Nice to see you back in PHP after your Mozilla adventures :)
>
> - Put it into a category and adjust the .php location accordingly.
> - Remove the release tgz from git
> - Run PHP_CodeSniffer on the code and fix it
> - @access is not needed
> - List allowed algorithms in @param $algo
> - add @throws at the relevant locations
> - tests don't run
>
> --
> http://pear.php.net/pepr/pepr-proposal-show.php?id=688
>