Re: [PEAR] Port Image_Color and Image_Canvas to PHP8
[email protected] (Mathieu Dubois) Mon, 25 Nov 2024 23:44:43 +0100
| Newsgroups | php.pear.general |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format.
--------------GSXZWFtpki0MX9qBBRQHEYO1
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Hello,
Following the progress from yesterday, I opened 2 PRs for Image_Color:
* #3 <https://github.com/pear/Image_Color/pull/3> adds GitHub actions
for the current code.
* #4 <https://github.com/pear/Image_Color/pull/4> ports the code to
PHP 8.4 (the branch is based on the branch from the previous PR so
it's best to first merge #3).
See the details on GitHub.
With that, I think one can create a new version of the Image_Color
package (1.0.7). This will be used to port Image_Canvas to PHP 8.
Thanks in advance,
Mathieu
Le 24/11/2024 à 22:28, Mathieu Dubois a écrit :
>
> Hi Chuck,
>
> Thanks for merging the CI PRs (for the interested reader, this is
> https://github.com/pear/Image_Color/pull/2 and
> https://github.com/pear/Image_Canvas/pull/6). I will open the new PR
> to port to PHP 8 ASAP. With a good CI, it will ease the job.
>
> Mathieu
>
> Le 24/11/2024 à 17:36, Chuck Burgess a écrit :
>> Sorry for the delay, looking at these this morning...
>> CRB
>> /about.me/ashnazg <http://about.me/ashnazg>/
>>
>>
>> On Fri, Nov 15, 2024 at 1:30 AM Mathieu Dubois
>> <[email protected]> wrote:
>>
>> Dear list,
>>
>> As I said on another thread about HTML_Template_IT, I haven't
>> received an answer about this. Anybody?
>>
>> Thanks in advance,
>> Mathieu
>>
>> Le 05/10/2024 à 03:13, Mathieu Dubois a écrit :
>>>
>>> Dear list,
>>>
>>> I took a bit of time to work on Image_Canvas (it was not without
>>> a bit of pain):
>>>
>>> * PR #6 (https://github.com/pear/Image_Canvas/pull/6)
>>> modernize the scripts and add GitHub actions for the current
>>> code.
>>> * Building on that, I was able to port to PHP 8. I will open
>>> the PR after #6 is merged.
>>>
>>> There are 3 caveats however:
>>>
>>> * PostScript output is not tested yet because I have some font
>>> issue and you need the PS extension
>>> (https://www.php.net/manual/en/book.ps.php). It should be
>>> doable.
>>> * PDF output is not tested because it uses the old PDFlib
>>> extension. This code needs to be re-done completely
>>> (probably based on FPDF).
>>> * As we require a version of Image_Color compatible with PHP
>>> 8, I use a branch in my fork (see composer.json). Of course,
>>> I will update that.
>>>
>>> Mathieu
>>>
>>> Le 02/10/2024 à 02:14, Mathieu Dubois a écrit :
>>>> Dear list,
>>>>
>>>> I need to (try to) port Image_Color and Image_Canvas (which
>>>> require Image_Color) to PHP 8.
>>>>
>>>> For Image_Color this is not too hard. As I did for
>>>> HTML_Template_IT, the goal is to keep compatibility from PHP
>>>> 5.6 to PHP 8. The main challenge is to have CI and be able run
>>>> the test s for a large span of PHP version (as PHPUnit changed
>>>> a lot in between). I opened a first PR
>>>> (https://github.com/pear/Image_Color/pull/2) to convert the
>>>> test suite to PHPUnitPolyFill which is very handy. for such cases
>>>>
>>>> I have 2 branches based on that to add GitHub actions (for CI)
>>>> and to port the code to PHP 8 (I will open the PR after).
>>>>
>>>> I haven't looked much to Image_Canvas for now but as the tests
>>>> don't use PHPUnit (it's simple scripts), it might be a bit
>>>> simpler.
>>>>
>>>> As before, I would appreciate any idea on that.
>>>>
>>>> Thanks in advance,
>>>> Mathieu
>>>>
>>> --
>>> Mathieu Dubois - IR - UMR 8030 équipe LABGeM
>>> CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France.
>>> Bureau B07
>>> +33 1 60 87 53 35
>>
>> --
>> Mathieu Dubois - IR - UMR 8030 équipe LABGeM
>> CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France.
>> Bureau B07
>> +33 1 60 87 53 35
>>
> --
> Mathieu Dubois - IR - UMR 8030 équipe LABGeM
> CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France.
> Bureau B07
> +33 1 60 87 53 35
--
Mathieu Dubois - IR - UMR 8030 équipe LABGeM
CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France.
Bureau B07
+33 1 60 87 53 35
--------------GSXZWFtpki0MX9qBBRQHEYO1
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello,</p>
<p>Following the progress from yesterday, I opened 2 PRs for
Image_Color:</p>
<ul>
<li><a moz-do-not-send="true"
href="https://github.com/pear/Image_Color/pull/3">#3</a> adds
GitHub actions for the current code.</li>
<li><a moz-do-not-send="true"
href="https://github.com/pear/Image_Color/pull/4">#4</a> ports
the code to PHP 8.4 (the branch is based on the branch from the
previous PR so it's best to first merge #3).</li>
</ul>
<p>See the details on GitHub.<br>
</p>
<p>With that, I think one can create a new version of the
Image_Color package (1.0.7). This will be used to port
Image_Canvas to PHP 8.</p>
<p>Thanks in advance,<br>
Mathieu<br>
</p>
<div class="moz-cite-prefix">Le 24/11/2024 à 22:28, Mathieu Dubois a
écrit :<br>
</div>
<blockquote type="cite"
cite="mid:[email protected]">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<p>Hi Chuck,</p>
<p>Thanks for merging the CI PRs (for the interested reader, this
is <a class="moz-txt-link-freetext"
href="https://github.com/pear/Image_Color/pull/2"
moz-do-not-send="true">https://github.com/pear/Image_Color/pull/2</a>
and <a class="moz-txt-link-freetext"
href="https://github.com/pear/Image_Canvas/pull/6"
moz-do-not-send="true">https://github.com/pear/Image_Canvas/pull/6</a>).
I will open the new PR to port to PHP 8 ASAP. With a good CI, it
will ease the job.<br>
</p>
<p>Mathieu<br>
</p>
<div class="moz-cite-prefix">Le 24/11/2024 à 17:36, Chuck Burgess
a écrit :<br>
</div>
<blockquote type="cite"
cite="mid:CANsgjntjp+PefVVxyBAykrtPO2mAKHFP8qXkuMzDm+YF+ua9LA@mail.gmail.com">
<meta http-equiv="content-type"
content="text/html; charset=UTF-8">
<div dir="ltr">
<div>Sorry for the delay, looking at these this morning...<br
clear="all">
</div>
<div>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">CRB<br>
<i><font size="1"><a href="http://about.me/ashnazg"
target="_blank" moz-do-not-send="true">about.me/ashnazg</a></font></i><br>
</div>
</div>
<br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Fri, Nov 15, 2024 at
1:30 AM Mathieu Dubois <<a
href="mailto:[email protected]"
moz-do-not-send="true" class="moz-txt-link-freetext">[email protected]</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Dear list,</p>
<p>As I said on another thread about HTML_Template_IT, I
haven't received an answer about this. Anybody?<br>
</p>
<p>Thanks in advance,<br>
Mathieu<br>
</p>
<div>Le 05/10/2024 à 03:13, Mathieu Dubois a écrit :<br>
</div>
<blockquote type="cite">
<p>Dear list,</p>
<p>I took a bit of time to work on <tt>Image_Canvas</tt>
(it was not without a bit of pain):</p>
<ul>
<li>PR #6 (<a
href="https://github.com/pear/Image_Canvas/pull/6"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">https://github.com/pear/Image_Canvas/pull/6</a>)
modernize the scripts and add GitHub actions for the
current code.</li>
<li>Building on that, I was able to port to PHP 8. I
will open the PR after #6 is merged.<br>
</li>
</ul>
<p>There are 3 caveats however:</p>
<ul>
<li>PostScript output is not tested yet because I have
some font issue and you need the PS extension (<a
href="https://www.php.net/manual/en/book.ps.php"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">https://www.php.net/manual/en/book.ps.php</a>).
It should be doable.<br>
</li>
<li>PDF output is not tested because it uses the old
PDFlib extension. This code needs to be re-done
completely (probably based on FPDF).</li>
<li>As we require a version of <tt>Image_Color</tt>
compatible with PHP 8, I use a branch in my fork
(see <tt>composer.json</tt>). Of course, I will
update that.<br>
</li>
</ul>
<p>Mathieu<br>
</p>
<div>Le 02/10/2024 à 02:14, Mathieu Dubois a écrit :<br>
</div>
<blockquote type="cite">Dear list, <br>
<br>
I need to (try to) port Image_Color and Image_Canvas
(which require Image_Color) to PHP 8. <br>
<br>
For Image_Color this is not too hard. As I did for
HTML_Template_IT, the goal is to keep compatibility
from PHP 5.6 to PHP 8. The main challenge is to have
CI and be able run the test s for a large span of PHP
version (as PHPUnit changed a lot in between). I
opened a first PR (<a
href="https://github.com/pear/Image_Color/pull/2"
target="_blank" moz-do-not-send="true"
class="moz-txt-link-freetext">https://github.com/pear/Image_Color/pull/2</a>)
to convert the test suite to PHPUnitPolyFill which is
very handy. for such cases <br>
<br>
I have 2 branches based on that to add GitHub actions
(for CI) and to port the code to PHP 8 (I will open
the PR after). <br>
<br>
I haven't looked much to Image_Canvas for now but as
the tests don't use PHPUnit (it's simple scripts), it
might be a bit simpler. <br>
<br>
As before, I would appreciate any idea on that. <br>
<br>
Thanks in advance, <br>
Mathieu <br>
<br>
</blockquote>
<pre cols="72">--
Mathieu Dubois - IR - UMR 8030 équipe LABGeM
CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France.
Bureau B07
+33 1 60 87 53 35</pre>
</blockquote>
<pre cols="72">--
Mathieu Dubois - IR - UMR 8030 équipe LABGeM
CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France.
Bureau B07
+33 1 60 87 53 35</pre>
</div>
</blockquote>
</div>
</blockquote>
<pre class="moz-signature" cols="72">--
Mathieu Dubois - IR - UMR 8030 équipe LABGeM
CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France.
Bureau B07
+33 1 60 87 53 35</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Mathieu Dubois - IR - UMR 8030 équipe LABGeM
CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France.
Bureau B07
+33 1 60 87 53 35</pre>
</body>
</html>
--------------GSXZWFtpki0MX9qBBRQHEYO1--