Re: [PEAR-QA] Net_GeoIP lacks a maintainer, and I'd like to take it over
[email protected] ("Daniel O'Connor")
| Newsgroups | php.pear.qa |
|---|---|
| Message-ID | <[email protected]> |
Great to hear that Josh! So; a few hoops to jump through first - code samples or patches. Since the one feature request that is open is.. well.. somewhat vague, it's kind of hard to implement. However, there are incomplete unit tests, or unit tests which skip. Feel like checking that out, and improving coverage? IE; if it needs special configuration or something, mocking that out? That'll give us a feel for your coding style and so forth. php -c ../php.ini -f /home/clockwerx/packages-all/Net_GeoIP/tests/AllTests.php PHPUnit 3.4.10 by Sebastian Bergmann. ISII Time: 0 seconds, Memory: 8.00Mb OK, but incomplete or skipped tests! Tests: 4, Assertions: 0, Incomplete: 3, Skipped: 1. -Daniel On Tue, Jun 1, 2010 at 5:38 AM, Josh Sherman <[email protected]> wrote: > Just started using the package and noticed it doesn't have a maintainer and > it has an open feature request. > > I'm requesting to become the maintainer of Net_GeoIP. > > Cheers! > > -j > http://joshtronic.com >