Re: Numbers_Words enconding

На 20.8.2010 г. 18:26, Igor Feghali написа:
> Hello Numbers_Words,
>
> AllTests.php is broken because of things like
> "declare(encoding='iso-8859-15')" :
>
> $ phpunit AllTests.php
> PHP Fatal error:  Encoding declaration pragma must be the very first
> statement in the script in
> /Users/Shared/NoBackUp/PEAR/Numbers_Words/tests/English100Test.php on
> line 2
>
> Fatal error: Encoding declaration pragma must be the very first
> statement in the script in
> /Users/Shared/NoBackUp/PEAR/Numbers_Words/tests/English100Test.php on
> line 2
>
>
> Having each driver at a specific encoding is a chaos IMO so I suggest
> that we move everything to UTF-8. any thoughts ?

I agree that having everything in UTF-8 would be great, but indeed as 
Christian pointed out, it would represent a BC break. And AFAIK PHP 
doesn't deal with Unicode well yet, so probably it's not a good idea to 
push users to use UTF-8, when PHP itself is not ready for it.

See also http://pear.php.net/bugs/bug.php?id=16732

> Also, I ask special attention to my last comment on:
>
> http://pear.php.net/bugs/bug.php?id=12512
>
> If you guys agree with that, I am ready to make the changes.

IMHO, it's a good idea.

> At last, how is package.xml being generated ? by hand ? I see no package.php.

I am writing it manually.

Regards,
-- 
Kouber Saparev
http://kouber.saparev.com