Re: Soliciting advice re german umlauts bug in XML_Feed_Parser
[email protected] (Melissa Draper) Wed, 15 Feb 2012 11:55:20 +1300
| Newsgroups | php.pear.qa |
|---|---|
| Message-ID | <CAMBy63hv1Mvt3vC6f2aiHKAM4tvXrJWL3-OG8raMy5RCH861hg@mail.gmail.com> |
Hi all, As it's no longer the Silly Season, I was wondering if anyone would be able to help with this at all. We want to get a new version of XML_Feed_Parser out soon. Thanks in advance, Melissa On Wed, Jan 4, 2012 at 8:35 PM, Melissa Draper <[email protected]>wrote: > Greetings, > > Many moons ago, this bug was reported > http://pear.php.net/bugs/bug.php?id=12916 against XML_Feed_Parser. > > A patch was uploaded, and a few weeks ago it was applied to the code base > by Daniel O'Connor. However, this code still fails the tests as seen here: > http://test.pear.php.net:8080/job/XML_Feed_Parser/lastBuild/testReport/junit/(root)/Regressions/test_handlesGermanUmlauts/ > > The best assumption I have is that the sample xml file for this test is > crap because however I view that file, the target characters in the sample > look "wrong"; either silly boxen or "euro, cross, ellipsis, big funky s, > big funky y, small funky s, overlapping s". > > > https://github.com/pear/XML_Feed_Parser/blob/master/tests/regressions.php#L67is the test, > https://github.com/pear/XML_Feed_Parser/blob/master/samples/bug12916.xmlis the sample. > > How valid is the assumption? Suggestions for a better fix? > > Thanks in advance. > -M >