Re: [PHP-PEAR] Output_Cache Module

Hi

the code looks very reasonable to me and more clean than mine was :)
maybe some optimization is necessary here and there (for example, too many
select queries in the db modules..)

and:

>I thought of a directory structure like this:
>$php_include_path/Cache.php
>$php_include_path/Cache/Cache_Output.php
>$php_include_path/Cache/Container/Cache_Container_file.php
>$php_include_path/Cache/Container/Cache_Container_(other_storage_types).php

if i understood the PEAR-Standard correctly, it would be more something
like this and in the DB-Stuff it's this way.:

$php_include_path/Cache.php
$php_include_path/Cache/Output.php
$php_include_path/Cache/Container/file.php
$php_include_path/Cache/Container/(other_storage_types).php

How should we proceed further?

I will setup a temporary cvs-server this afternoon and give me and vinai
write access. so we can better work together on that...

i'll post the access data later this day.

And last, but not least: What are the chances to get that into PEAR? What
are the requirements?

that's it for the moment

chregu

On Today, Vinai Kopp wrote:

>
>
> Christian Stocker wrote:
>
> > > I moved the container logic for the DB and the fileBack end into
> > > separate classes ( Cache_Container_db and Cache_Container_file) and made
> > > a generic Cache class that is a parent of Cache_Output. It can handle
> >
> > didn't really get that. My code seperated DB and file logic as well in
> > different classes (Cache_Output_File and Cache_Output_DB) and there was a
> > master class (Cache_Output). Did i do something not correct with that?
> > (i'm fairly new to php-oo-design and very eager to learn more about that.)
> > Maybe if i see your code, it's logic for me as well.
>
> I didn't change very much, you can see for yourself:
> http://vinais.home-in-the.net/pear/cache/
>
> Mostly renaming the Classes because they aren't only for caching output
> now :)
> I added the isExpired functions as well...
>
> >
> > > I'll post an url later on today when I'm through making the changes.
> >
>
> took longer than I wanted.
>
> Comments, Questions, Critic etc. are of course very welcome,
>
> Vinai
>

-- 
nam...christian stocker    adr...bremgartnerstr. 66, ch-8003 zurich
pho...+41  1 451 6021      www...http://phant.ch/chregu
mob...+41 76 561 8860      [email protected]