[PECL-CVS] [pecl-database-ibm_db2] use-out-length: Try to use out_length for bound fetched values

Author: Calvin Buckley (NattyNarwhal)
Date: 2025-10-03T17:17:06-03:00

Commit: https://github.com/php/pecl-database-ibm_db2/commit/22ebfb7e3eb0d32d0889e5934c3fd3741fc8a917
Raw diff: https://github.com/php/pecl-database-ibm_db2/commit/22ebfb7e3eb0d32d0889e5934c3fd3741fc8a917.diff

Try to use out_length for bound fetched values

I have no idea why it's using strlen in the first place, but if SQL/CLI
returns junk in the buffer, then the length might be correct. This
matches what we did with column names on IBM i.

The SQL_BINARY case is more puzzling, but we can take a look at it later
if this works for strings. Why is it ifdef'd to use strlen/out_length
depending on platform?

Changed paths:
  M  ibm_db2.c


Diff:

diff --git a/ibm_db2.c b/ibm_db2.c
index f1b61aa..d119cdc 100644
--- a/ibm_db2.c
+++ b/ibm_db2.c
@@ -6289,7 +6289,7 @@ static void _php_db2_bind_fetch_helper(INTERNAL_FUNCTION_PARAMETERS, int op)
                 case SQL_DECFLOAT:
 #ifdef PASE /* i5/OS trim spaces */
                     if (stmt_res->s_i5_conn_parent->c_i5_char_trim > 0) {
-                        i5trim = strlen((char *)row_data->str_val);
+                        i5trim = out_length;
                         for(; i5trim >= 0; i5trim--) {
                             i5char = (char)(((char *)row_data->str_val)[i5trim]);
                             if (i5char == 0x00 || i5char == 0x20) {
@@ -6316,11 +6316,11 @@ static void _php_db2_bind_fetch_helper(INTERNAL_FUNCTION_PARAMETERS, int op)
 #endif /* PASE */
                     if ( op & DB2_FETCH_ASSOC ) {
                         add_assoc_stringl(return_value, (char *)stmt_res->column_info[i].name,
-                            (char *)row_data->str_val, strlen((char *)row_data->str_val));
+                            (char *)row_data->str_val, out_length);
                     }
                     if ( op & DB2_FETCH_INDEX ) {
                         add_index_stringl(return_value, i, (char *)row_data->str_val,
-                            strlen((char *)row_data->str_val));
+                            out_length);
                     }
                     break;
                 case SQL_BOOLEAN: