[PECL-CVS] [pecl-networking-ssh2] fix/allocator-mismatch-libssh2-1828: address reviews
[email protected] (Rasmus Lerdorf) Fri, 3 Apr 2026 09:12:31 +0000
| Newsgroups | php.pecl.cvs |
|---|---|
| Message-ID | <[email protected]> |
Author: Rasmus Lerdorf (rlerdorf)
Date: 2026-04-03T05:12:23-04:00
Commit: https://github.com/php/pecl-networking-ssh2/commit/bb07c8bc78fc949b65da3644977b77814357318d
Raw diff: https://github.com/php/pecl-networking-ssh2/commit/bb07c8bc78fc949b65da3644977b77814357318d.diff
address reviews
Changed paths:
M ssh2.c
Diff:
diff --git a/ssh2.c b/ssh2.c
index 7293361..70093b4 100644
--- a/ssh2.c
+++ b/ssh2.c
@@ -602,7 +602,7 @@ static void kbd_callback(const char *name, int name_len,
(void)instruction_len;
if (num_prompts == 1) {
responses[0].text = strdup(password_for_kbd_callback);
- responses[0].length = strlen(password_for_kbd_callback);
+ responses[0].length = responses[0].text ? strlen(password_for_kbd_callback) : 0;
}
(void)prompts;
(void)abstract;