[PECL-CVS] [pecl-networking-ssh2] feature/keepalive-support: address reviews

[email protected] (Rasmus Lerdorf) Sat, 4 Apr 2026 11:36:59 +0000
Newsgroups php.pecl.cvs
Message-ID <[email protected]>
Author: Rasmus Lerdorf (rlerdorf)
Date: 2026-04-04T07:36:51-04:00

Commit: https://github.com/php/pecl-networking-ssh2/commit/57c2fe17011d85dca501ad7591ef33a87afcc642
Raw diff: https://github.com/php/pecl-networking-ssh2/commit/57c2fe17011d85dca501ad7591ef33a87afcc642.diff

address reviews

Changed paths:
  M  ssh2.c


Diff:

diff --git a/ssh2.c b/ssh2.c
index 953e0a5..8bd51cb 100644
--- a/ssh2.c
+++ b/ssh2.c
@@ -493,8 +493,8 @@ PHP_FUNCTION(ssh2_keepalive_config)
 		return;
 	}
 
-	if (interval < 0) {
-		php_error_docref(NULL, E_WARNING, "Argument #3 ($interval) must be greater than or equal to 0");
+	if (interval < 0 || interval > UINT_MAX) {
+		php_error_docref(NULL, E_WARNING, "Argument #3 ($interval) must be between 0 and %u", UINT_MAX);
 		return;
 	}