[PECL-CVS] [pecl-networking-gearman] expose-stop-wait-on-signal: address reviews

Author: Rasmus Lerdorf (rlerdorf)
Date: 2026-04-04T09:07:52-04:00

Commit: https://github.com/php/pecl-networking-gearman/commit/3fbdae7bccdc5d01d6fc32fa6f39206b0f26197d
Raw diff: https://github.com/php/pecl-networking-gearman/commit/3fbdae7bccdc5d01d6fc32fa6f39206b0f26197d.diff

address reviews

Changed paths:
  M  tests/gearman_client_023.phpt
  M  tests/gearman_worker_019.phpt


Diff:

diff --git a/tests/gearman_client_023.phpt b/tests/gearman_client_023.phpt
index 95dee1f..a377fd2 100644
--- a/tests/gearman_client_023.phpt
+++ b/tests/gearman_client_023.phpt
@@ -2,13 +2,12 @@
 GEARMAN_CLIENT_STOP_WAIT_ON_SIGNAL constant and addOptions()
 --SKIPIF--
 <?php
-if (!extension_loaded("gearman")) print "skip";
-if (!defined("GEARMAN_CLIENT_STOP_WAIT_ON_SIGNAL")) print "skip libgearman too old";
+if (!extension_loaded("gearman")) die("skip");
+if (!defined("GEARMAN_CLIENT_STOP_WAIT_ON_SIGNAL")) die("skip libgearman too old");
 ?>
 --FILE--
 <?php
 $client = new GearmanClient();
-$before = $client->options();
 $client->addOptions(GEARMAN_CLIENT_STOP_WAIT_ON_SIGNAL);
 $after = $client->options();
 var_dump(($after & GEARMAN_CLIENT_STOP_WAIT_ON_SIGNAL) !== 0);
diff --git a/tests/gearman_worker_019.phpt b/tests/gearman_worker_019.phpt
index 6d27fd7..bd7b282 100644
--- a/tests/gearman_worker_019.phpt
+++ b/tests/gearman_worker_019.phpt
@@ -2,13 +2,12 @@
 GEARMAN_WORKER_STOP_WAIT_ON_SIGNAL constant and addOptions()
 --SKIPIF--
 <?php
-if (!extension_loaded("gearman")) print "skip";
-if (!defined("GEARMAN_WORKER_STOP_WAIT_ON_SIGNAL")) print "skip libgearman too old";
+if (!extension_loaded("gearman")) die("skip");
+if (!defined("GEARMAN_WORKER_STOP_WAIT_ON_SIGNAL")) die("skip libgearman too old");
 ?>
 --FILE--
 <?php
 $worker = new GearmanWorker();
-$before = $worker->options();
 $worker->addOptions(GEARMAN_WORKER_STOP_WAIT_ON_SIGNAL);
 $after = $worker->options();
 var_dump(($after & GEARMAN_WORKER_STOP_WAIT_ON_SIGNAL) !== 0);