[PECL-CVS] [pecl-networking-gearman] master: Merge pull request #57 from php/fix-worker-ctor-cleanup

[email protected] (Rasmus Lerdorf via GitHub) Sat, 4 Apr 2026 17:58:02 +0000
Newsgroups php.pecl.cvs
Message-ID <[email protected]>
Author: Rasmus Lerdorf (rlerdorf)
Committer: GitHub (web-flow)
Pusher: rlerdorf
Date: 2026-04-04T18:57:59+01:00

Commit: https://github.com/php/pecl-networking-gearman/commit/00fad6d02ec48e115e4688b3f6a05089df6bd160
Raw diff: https://github.com/php/pecl-networking-gearman/commit/00fad6d02ec48e115e4688b3f6a05089df6bd160.diff

Merge pull request #57 from php/fix-worker-ctor-cleanup

Remove stray zval_ptr_dtor_nogc() call

Changed paths:
  M  php_gearman_worker.c


Diff:

diff --git a/php_gearman_worker.c b/php_gearman_worker.c
index d90f961..3263bea 100644
--- a/php_gearman_worker.c
+++ b/php_gearman_worker.c
@@ -26,7 +26,6 @@ static void gearman_worker_ctor(INTERNAL_FUNCTION_PARAMETERS) {
 	worker = Z_GEARMAN_WORKER_P(return_value);
 
 	if (gearman_worker_create(&(worker->worker)) == NULL) {
-		zval_ptr_dtor_nogc(return_value);
 		GEARMAN_EXCEPTION("Memory allocation failure", 0);
 	}