[PECL-CVS] [pecl-web_services-oauth] fix-curl-mime-deprecation: address reviews
[email protected] (Rasmus Lerdorf) Sat, 4 Apr 2026 22:27:32 +0000
| Newsgroups | php.pecl.cvs |
|---|---|
| Message-ID | <[email protected]> |
Author: Rasmus Lerdorf (rlerdorf)
Date: 2026-04-04T18:27:27-04:00
Commit: https://github.com/php/pecl-web_services-oauth/commit/397b7cded7329665e7b7089a4fd376305e82e61f
Raw diff: https://github.com/php/pecl-web_services-oauth/commit/397b7cded7329665e7b7089a4fd376305e82e61f.diff
address reviews
Changed paths:
M oauth.c
Diff:
diff --git a/oauth.c b/oauth.c
index 89b0372..f1b28fe 100644
--- a/oauth.c
+++ b/oauth.c
@@ -1162,7 +1162,10 @@ long make_req_curl(php_so_object *soo, const char *url, const smart_string *payl
if (mres == CURLE_OK) mres = curl_mime_filename(part, filename ? filename + sizeof(";filename=") - 1 : postval);
if (mres == CURLE_OK) mres = curl_mime_type(part, type ? type + sizeof(";type=") - 1 : "application/octet-stream");
if (mres != CURLE_OK) {
- soo_handle_error(soo, -1, "failed to set curl mime part data", NULL, NULL);
+ char *em;
+ spprintf(&em, 0, "failed to set curl mime part data (%s)", curl_easy_strerror(mres));
+ soo_handle_error(soo, -1, em, NULL, NULL);
+ efree(em);
efree(postval_orig);
goto cleanup;
}
@@ -1176,7 +1179,10 @@ long make_req_curl(php_so_object *soo, const char *url, const smart_string *payl
mres = curl_mime_name(part, soo->multipart_params[i]);
if (mres == CURLE_OK) mres = curl_mime_data(part, postval, CURL_ZERO_TERMINATED);
if (mres != CURLE_OK) {
- soo_handle_error(soo, -1, "failed to set curl mime part data", NULL, NULL);
+ char *em;
+ spprintf(&em, 0, "failed to set curl mime part data (%s)", curl_easy_strerror(mres));
+ soo_handle_error(soo, -1, em, NULL, NULL);
+ efree(em);
efree(postval_orig);
goto cleanup;
}