[PECL-CVS] [pecl-networking-gearman] ci-incompatible-pointer-types: use step-level env for CFLAGS instead of php-config inline

[email protected] (Rasmus Lerdorf) Thu, 9 Apr 2026 15:58:36 +0000
Newsgroups php.pecl.cvs
Message-ID <[email protected]>
Author: Rasmus Lerdorf (rlerdorf)
Date: 2026-04-09T11:58:28-04:00

Commit: https://github.com/php/pecl-networking-gearman/commit/02c728e344b617dc59578d123258cf789555b0d9
Raw diff: https://github.com/php/pecl-networking-gearman/commit/02c728e344b617dc59578d123258cf789555b0d9.diff

use step-level env for CFLAGS instead of php-config inline

The php-config --cflags approach injected a newline into CFLAGS, breaking
configure's compiler check on all builds. Use step-level env: instead —
config.m4 already appends -Wall to CFLAGS, and the phpize build system
handles PHP's own flags separately.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Changed paths:
  M  .github/workflows/ci.yml


Diff:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6d66a42..1647bd8 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -40,15 +40,15 @@ jobs:
 
       - name: Configure macOS
         if: ${{ matrix.os == 'macos-latest' }}
-        run: |
-          CFLAGS="$(php-config --cflags) -Werror=incompatible-pointer-types" \
-            ./configure --with-gearman=$(brew --prefix gearman)
+        run: ./configure --with-gearman=$(brew --prefix gearman)
+        env:
+          CFLAGS: -Werror=incompatible-pointer-types
 
       - name: Configure Linux
         if: ${{ matrix.os == 'ubuntu-latest' }}
-        run: |
-          CFLAGS="$(php-config --cflags) -Werror=incompatible-pointer-types" \
-            ./configure --with-gearman
+        run: ./configure --with-gearman
+        env:
+          CFLAGS: -Werror=incompatible-pointer-types
 
       - name: Make extension
         run: make