[PECL-CVS] [pecl-math-stats] fix/stats_stat_correlation: address reviews

[email protected] (Rasmus Lerdorf) Tue, 21 Apr 2026 03:17:06 +0000
Newsgroups php.pecl.cvs
Message-ID <[email protected]>
Author: Rasmus Lerdorf (rlerdorf)
Date: 2026-04-20T23:16:58-04:00

Commit: https://github.com/php/pecl-math-stats/commit/56b86488001e884c4e189494ba3a193607e53669
Raw diff: https://github.com/php/pecl-math-stats/commit/56b86488001e884c4e189494ba3a193607e53669.diff

address reviews

Changed paths:
  M  package.xml
  M  tests/stats_stat_correlation_degenerate.phpt


Diff:

diff --git a/package.xml b/package.xml
index 65e50cb..56f93ef 100644
--- a/package.xml
+++ b/package.xml
@@ -125,6 +125,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
     <file name="stats_standard_deviation.phpt" role="test" />
     <file name="stats_stat_binomial_coef.phpt" role="test" />
     <file name="stats_stat_correlation.phpt" role="test" />
+    <file name="stats_stat_correlation_degenerate.phpt" role="test" />
     <file name="stats_stat_factorial.phpt" role="test" />
     <file name="stats_stat_independent_t.phpt" role="test" />
     <file name="stats_stat_innerproduct.phpt" role="test" />
diff --git a/tests/stats_stat_correlation_degenerate.phpt b/tests/stats_stat_correlation_degenerate.phpt
index f51d506..493d0ab 100644
--- a/tests/stats_stat_correlation_degenerate.phpt
+++ b/tests/stats_stat_correlation_degenerate.phpt
@@ -3,16 +3,16 @@ stats_stat_correlation() degenerate inputs
 --FILE--
 <?php
 // empty arrays
-var_dump(stats_stat_correlation([], []));
+var_dump(stats_stat_correlation(array(), array()));
 
 // single-element arrays
-var_dump(stats_stat_correlation([1], [2]));
+var_dump(stats_stat_correlation(array(1), array(2)));
 
 // zero variance in X
-var_dump(stats_stat_correlation([1, 1, 1], [1, 2, 3]));
+var_dump(stats_stat_correlation(array(1, 1, 1), array(1, 2, 3)));
 
 // zero variance in Y
-var_dump(stats_stat_correlation([1, 2, 3], [5, 5, 5]));
+var_dump(stats_stat_correlation(array(1, 2, 3), array(5, 5, 5)));
 ?>
 --EXPECTF--
 Warning: stats_stat_correlation(): Correlation requires at least 2 data points in %s on line %d