Re: [PECL-DEV] I would like to take over PAM extension which is inactive since 2009

On 07/06/21 6:33 pm, Remi Collet wrote:
> Hi,
>
> I noticed version 2.2.1 have been published on pecl
>
> So, questions
>
> 1/ Where are the sources ?
>
> Seems the linked github project is outdated (on 2.1 there) and no 
> package.xml
>
I just became maintainer of this package on PECL where I published 
2.2.1. Still learning how to use PECL website.

I will update Github soon. Btw, Github is on 2.2 not 2.1.

> 2/ Supported versions
>
> You say 7/8 but package.xml states > 8.0
> Is it expected (will be nice to have all maintained versions)

I use Arch Linux which supported PHP 7 till January. And then Arch Linux 
moved to PHP 8.

And hence I had to fix the code to run on PHP 8.

https://github.com/amishmm/php-pam/commit/efa0bf4079c2fd0cf8880a9aba1a9e7077a60648

I am not a regular PHP coder. So I do not know how to "easily" make 
above commit work on both PHP 7 and PHP 8.

I know I need to put #ifdef but #ifdef on what variable?

If you know then please provide a PR or hint.

> 3/ ZTS
>
> Looks like ZTS support is not ready
> Segfault when  run with extension enabled
>
> (gdb) bt
> #0  zend_post_startup () at 
> /usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/Zend/zend.c:1015
> #1  0x000055555577a59d in php_module_startup (sf=<optimized out>, 
> additional_modules=<optimized out>, num_additional_modules=<optimized 
> out>)
>     at /usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/main/main.c:2373
> #2  0x0000555555877cc1 in php_cli_startup (sapi_module=<optimized 
> out>) at 
> /usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/sapi/cli/php_cli.c:410
> #3  0x000055555563f45b in main (argc=6, argv=0x555555e1b230) at 
> /usr/src/debug/php-7.4.20-1.fc33.remi.x86_64/sapi/cli/php_cli.c:1326
>
I see that you have provided the PR. I will commit it soon.

Thanks.

Amish