Re: new rrd tool extension

[email protected] (Miroslav Kubelík - seznam) Tue, 11 May 2010 10:19:31 +0200

Newsgroups	php.pecl.dev
Organization	Home email
Message-ID	<[email protected]>

On Mon, 10 May 2010 19:27:38 +0200, Johannes Schlüter  
<[email protected]> wrote:

> Quick review looks fine, a few small comments though:
>
>       * rrdtool uses GPL with FLOSS Exception. Exception is valid for
>         PHp License 3.0, not the current version 3.01, could you talk to
>         the rrdtool maintainers to add version 3.01?

OK, I'll try.

>       * in rrd.c you're using C99/C++ comments, please use always /* */
>         instead of //.
> ....

Thanks, I'll fix, then I'll send a new message with a result.

M. Kubelik