com pftt2: Fix #67: PHP Deprecated causes failures: src/com/mostc/pftt/model/smoke/RequiredExtensionsSmokeTest.java
[email protected] (Christoph Michael Becker)
| Newsgroups | php.qa |
|---|---|
| Message-ID | <[email protected]> |
Commit: 2f9a2945a948569229f2cada3bbbbad42d8e8d46 Author: Christoph M. Becker <[email protected]> Thu, 17 Oct 2019 12:34:55 +0200 Parents: 8ef1c24a647d70c53a1f2d6b894e8d20f521e676 Branches: master Link: http://git.php.net/?p=pftt2.git;a=commitdiff;h=2f9a2945a948569229f2cada3bbbbad42d8e8d46 Log: Fix #67: PHP Deprecated causes failures We have to use the same error reporting related settings as run-tests.php, since some of the tests rely on that regarding the expected output. Bugs: https://bugs.php.net/67 Changed paths: M src/com/mostc/pftt/model/smoke/RequiredExtensionsSmokeTest.java Diff: diff --git a/src/com/mostc/pftt/model/smoke/RequiredExtensionsSmokeTest.java b/src/com/mostc/pftt/model/smoke/RequiredExtensionsSmokeTest.java index 336fc5d3..c3a49eb4 100644 --- a/src/com/mostc/pftt/model/smoke/RequiredExtensionsSmokeTest.java +++ b/src/com/mostc/pftt/model/smoke/RequiredExtensionsSmokeTest.java @@ -217,22 +217,16 @@ public class RequiredExtensionsSmokeTest extends SmokeTest { // // CRITICAL - // be very careful changing ERROR_REPORTING. it can cause false failures. - // WHENEVER changing this setting, you MUST test a ts and nts build from 5.3, 5.4, 5.5 with at least CLI and Apache scenarios - // before AND after to make sure this didn't break anything. PHPT tests are especially sensitive to this setting (can cause false PHPT failures). - // - // testing 5.3 is especially important - // - // NOTE: 5.3 php builds do not include E_STRICT with E_ALL. you must explicitly include both here! - ini.putMulti(PhpIni.ERROR_REPORTING, "E_ALL ^ E_WARNING");//NONE"); + // ERROR_REPORTING has to match the setting in run-tests.php, since some tests rely on that. + ini.putMulti(PhpIni.ERROR_REPORTING, "E_ALL | E_STRICT"); // CRITICAL ini.putMulti(PhpIni.DISPLAY_ERRORS, PhpIni.ON); // TODO temp ? ini.putSingle("date.timezone", "UTC"); // CRITICAL - ini.putMulti(PhpIni.DISPLAY_STARTUP_ERRORS, PhpIni.OFF); + ini.putMulti(PhpIni.DISPLAY_STARTUP_ERRORS, PhpIni.ON); // CRITICAL - ini.putMulti(PhpIni.LOG_ERRORS, PhpIni.ON); // TODO temp + ini.putMulti(PhpIni.LOG_ERRORS, PhpIni.OFF); // CRITICAL ini.putMulti(PhpIni.HTML_ERRORS, PhpIni.OFF);