about code cleanup / coding standard

[email protected] (Sebastian Mendel) Wed, 13 Jun 2007 09:19:40 +0200
Newsgroups php.smarty.dev
Message-ID <[email protected]>
Hi,

i have read through "[patch] code clenaup"

and i think it owuld be nice if Smarty would  follow some clearly defined
coding standard, i think PEAR is well one, i personally prefer over zend
framework

i think Smarty code base is close to PEAR coding standard in most places

there are just some inconsistencies, f.e.

'string' . $var vs. 'string'.$var
"string $var" vs. 'string ' . $var
if( vs. if (
array(
    el);
vs.
array(
    el
);

missing ',' after last array element


i also know all the trouble that such a code cleanup does (diff between
versions with minor code cahnges but huge formating changes are blowed up)

but doing this is a relatively easy step - just use some source formating
tool, f.e.:

http://www.waterproof.fr/products/phpCodeBeautifier/manual.php



-- 
Sebastian Mendel

www.sebastianmendel.de