Re: [PHP4BETA] cvs: php4 /ext/calendar/ calendar.c

[email protected] (Sascha Schumann) Mon, 22 May 2000 23:32:20 +0200 (MEST)

Newsgroups	php.version4
Message-ID	<[email protected]>

On Mon, 22 May 2000, Zeev Suraski wrote:

> zeev		Mon May 22 17:49:49 2000 EDT
> 
>   Modified files:
>     /php4/ext/calendar	calendar.c 
>   Log:
>   - Make calendar compile as a dll on Windows
>   
>   
> Index: php4/ext/calendar/calendar.c
> diff -u php4/ext/calendar/calendar.c:1.5 php4/ext/calendar/calendar.c:1.6
> --- php4/ext/calendar/calendar.c:1.5	Thu May 18 17:34:22 2000
> +++ php4/ext/calendar/calendar.c	Mon May 22 17:49:49 2000
> @@ -53,7 +53,7 @@
>    STANDARD_MODULE_PROPERTIES,
>  };
>  
> -#ifdef COMPILE_DL_CALENDAR
> +#if COMPILE_DL

Please use this instead:

#if defined(COMPILE_DL_CALENDAR) || defined(COMPILE_DL)

This makes the calendar module buildable as shared module on Windows and
Unix. Down the road, I think we should migrate to using the
COMPILE_DL_NAME stuff, because it is more finegrained. Currently, most
modules use the above line which checks for both macros.

- Sascha