Re: [PHP4BETA] cvs: php4 /ext/standard/ basic_functions.c basic_functions.h php_noavail.c php_noavail.h

On Mon, 29 May 2000, Hartmut Holzgraefe wrote:

> 1) the mechanism behind warn_not_available() is not limit to
> php4/ext/standard
>    so i wasn't sure it should be in php4/ext/standard or in php4/
> 
>    puttig the implementation in a file of its own allows moving it
> somewhere
>    else without trouble

That applies to lots of other functions in standard - that's why they're
in the standard directory in the first place...  Enforcing people to
#include basic_functions.h to get this functionality is not a big deal,
or, it could be in one of the standard PHP headers like Andi suggested.
Having a separate file is unnecessary bloat IMO.

 > 
> 2) the prototype for warn_not_available() is needed by other modules
>    (especially ext/imap) that i didn't check in yet
>    that's what the .h file and it's inclusion into php.h was for
>    
>    removing this does still work in the repository as of now but breaks
>    some other modules i didn't check in yet that make use of 
>   
> PHP_ALIAS(some_function_not_available_for_some_reason,warn_not_available,NULL)
> 
>    :(

#include basic_functions.h for now, it IS ok for modules to rely on code
from the standard/ directory - it's not like any other module.

> > +       PHP_FE(warn_not_available,                      NULL)
> 
> warn_not_available is for internal use in alias entries for functions
> not available and should not be visible to the user 
> (as it does not provide any functionality suitable for userspace)

Oh, I'm well aware of it.  I even pointed out that it won't be a problem
to alias to it, without having it in the function namespace at all a few
days ago...  It was added by mistake.

Zeev

-- 
Zeev Suraski <[email protected]>
http://www.zend.com/