Re: [PHP4BETA] proposed fopen_wrappers generalization / patch v.2

At 08:58 PM 6/7/00 +0200, Hartmut Holzgraefe wrote:
>I didn't do a checkin yet as i am not sure about the follwing issues:
>
>- Did i really get those HashTable functions right?

When you commit the code I can take a look at the hash function calls.


>- Where is the best place for the init/shutdown functions?
>   Currently they are in php_module_startup/shutdown
>   immediately before php_startup_internal_extensions() /
>   after php_config_ini_shutdown()?

That sounds the right place to put it. I would have automatically said 
"before the startup of internal extensions" :)
What kind of initializing are you doing? Hmm, I can't find the patch 
anymore. Maybe you can resend it? :)


>- What should happen if two modules try to register a wrapper for
>   the same URL type ?

Not sure. There are a few options and they are all pretty equally as good 
because it doesn't make much sense. Either print a warning but ignore 
further requests, print an error and die, and so on.



>i have tried it so far with linux and solaris, cgi and apxs,
>'test:'-module staticly linked in, without problems
>
>
>now this is almost as long as the patch itself ... :)

Yeah but it was worth it. Now I really understand what you were doing.

Andi
---
Andi Gutmans <[email protected]>
http://www.zend.com/