Re: [PHP-WEBMASTER] svn: /web/php/trunk/ images/shade.png include/header.inc include/layout.inc js/common.js js/jquery.hoverIntent.minified.js styles/structure.css styles/theme.css

On Sat, Jan 1, 2011 at 19:30, Stewart Lord <[email protected]> wrote:
>
> On 2011-01-01, at 5:12 AM, Hannes Magnusson wrote:
>
>> The JS seems unnecessary complicated to me..
>> If we move the megadropdown item into its div, and simply show/hide
>> the js becomes heckofalot simpler, and ignores the doubleclick issue.
>>
>> See attached patch.
>>
>> -Hannes
>> <megadropfix.patch.txt>
>
>
> Hi Hannes,
>
> If there is a expanded menu, you slide it up and, at the same time, slide the new menu down. This results in an odd effect because we are animating the two menus simultaneously. I think we should slide the new menu down after the slide up animation completes via a callback (as before).
>

Trivial fix.

> Another, less important issue. Previously the sub-menus lived in the list with their parent links which from a semantic html perspective is more correct. By moving the sub-menus around in the dom, we are compromising the structure of our html to make our JS easier. Can't say I care too much about that though.
>

One of the reasons why I didn't commit it :]

I still haven't thought of a better way to fix this easily.

-Hannes