Re: [PHP-WEBMASTER] svn: /web/php/trunk/include/ header.inc

[email protected] (Hannes Magnusson)
Newsgroups php.webmaster
Message-ID <[email protected]>
On Fri, Jan 7, 2011 at 12:20, Adam Harvey <[email protected]> wrote:
> aharvey                                  Fri, 07 Jan 2011 11:20:22 +0000
>
> Revision: http://svn.php.net/viewvc?view=revision&revision=307218
>
> Log:
> Fix the mega drop down background colour overflowing in IE ≤ 7. (I'm presuming
> we don't really care about IE 6, but 7 might just about be worth still vaguely
> trying to support a bit.)
>
> Changed paths:
>    U   web/php/trunk/include/header.inc
>
> Modified: web/php/trunk/include/header.inc
> ===================================================================
> --- web/php/trunk/include/header.inc    2011-01-07 11:08:57 UTC (rev 307217)
> +++ web/php/trunk/include/header.inc    2011-01-07 11:20:22 UTC (rev 307218)
> @@ -53,6 +53,12 @@
>  <link rel="stylesheet" type="text/css" href="<?php echo $STATIC_ROOT ?>styles/home.css<?php echo $v?>" media="screen" />
>  <link rel="stylesheet" type="text/css" href="<?php echo $STATIC_ROOT ?>styles/dynamic.php<?php echo $v?>" media="screen" />
>
> + <!--[if lte IE 7]>
> + <style type="text/css">
> +  #layout { background: white; }
> + </style>
> + <![endif]-->


IMO browser specific workaround needs to be self contained in
styles/workarounds.<browser>.css, not in the header.

-Hannes
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.