Re: [PHP-WEBMASTER] svn: /web/php/trunk/ include/header.inc styles/home.css

On Sat, Jan 8, 2011 at 19:15, Paul Dragoonis <[email protected]> wrote:
> dragoonis                                Sat, 08 Jan 2011 18:15:46 +0000
>
> Revision: http://svn.php.net/viewvc?view=revision&revision=307273
>
> Log:
> Changes to the homepage downloads area: Now we have a link to the gz, bz2 and the windows section for each release
>
> Changed paths:
>    U   web/php/trunk/include/header.inc
>    U   web/php/trunk/styles/home.css
>
> Modified: web/php/trunk/include/header.inc
> ===================================================================
> --- web/php/trunk/include/header.inc    2011-01-08 17:24:36 UTC (rev 307272)
> +++ web/php/trunk/include/header.inc    2011-01-08 18:15:46 UTC (rev 307273)
> @@ -85,7 +85,6 @@
>     </span>
>   </div>
>  </div>
> -
>  <nav id="headnav">
>
>  <ul id="headmenu">
> @@ -113,20 +112,26 @@
>             <p class="tutorial"><a href="/tut.php">Introductory Tutorial &raquo;</a></p>
>         </div>
>         <div class="download">
> -<?php foreach ($RELEASES[5] as $version => $release): ?>
> -            <a href="/get/<?php echo $release['source'][0]['filename'] ?>/from/a/mirror">
> -                <span class="version">PHP <?php echo $version ?></span>
> -                <span class="package">Complete Source Code</span>
> -                <span class="file">
> -                    <?php echo $release['source'][0]['filename'] ?>
> -                    <!-- (size) should go here, but it's not in version.inc at present -->
> -                </span>
> -            </a>
> -<?php endforeach; ?>
> -            <a href="http://windows.php.net" class="windows">
> -                <span class="version">Windows Downloads</span>
> -                <span class="date">http://windows.php.net/</span>
> -            </a>
> +<?php if(!empty($RELEASES[5])): ?>
> +               <ul>
> +       <?php
> +       foreach ($RELEASES[5] as $version => $release):
> +               $windowsVersionLink = substr($version, 0, strrpos($version, '.'));
> +       ?>
> +                               <li>
> +                           <a href="/get/<?php echo $release['source'][1]['filename'] ?>/from/a/mirror" class="version">PHP <?php echo $version ?></a>
> +                           <a href="/get/<?php echo $release['source'][0]['filename'] ?>/from/a/mirror">Download as bz2</a>
> +                                       <a href="http://windows.php.net/download/#php-<?php echo $windowsVersionLink; ?>">Download for windows</a>
> +                           <!-- (size) should go here, but it's not in version.inc at present -->

Whats the dealio with WS here, and why don't you use download_link()?

This feels a bit awkward. How about "Other types: [bz2] | [Windows]"
or something like that?



> +                       </li>
> +       <?php endforeach; ?>
> +
> +                   <li class="windows">
> +                       <a href="http://windows.php.net/" title="">Download for windowss</a>
> +                       <a href="http://windows.php.net/" title=>http://windows.php.net/</a>
> +                   </li>
> +               </ul>


That should be removed since the windows links are already in the
others. The various markup errors and typos atleast fixed.

-Hannes