Re: [PHP-XML-DEV] import_node patch

[email protected] (Christian Stocker)
Newsgroups php.xml.dev
Message-ID <[email protected]>
Hi eric

I'll check your patch later this day

> Here is a patch to import_node in domxml. I don't know where else to
> send it since mail to the original author didn't get a response. Perhaps
> someone can inform me of the correct place to send it.
>
> This patch does two things:
>
> (1) renames imported_node to import_node to follow the DOM function
> naming.

i'll  make an alias out of it. I don't want to remove functions in stable
releases...

> (2) makes sure that the (new) owner document is set properly for all
> descendants in the imported subtree, instead of just the node itself.

very good. I think, noone else used imported_node before (strange name
anyway...)

- Some Issues:

- It's maybe better to use xmlDocCopyNode than xmlCopyNode. Didn't look
into the code about the differences...

- Check for not allowed Node types

I can check this stuff, if you don't know enough about it, but this will
take some time (as i'm busy..). If you can do it and send me the patch
it will get integrated much faster ;)

chregu
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.