Re: [PHP-XML-DEV] domxml in PHP5
[email protected] ("Rob Richards")
| Newsgroups | php.xml.dev |
|---|---|
| Message-ID | <[email protected]> |
So, in short, we shouldn't add any more functionality into the extension (as it wont be going into the 4_3 branch anyways), and concentrate on memory issues (as these would work for both) and/or layout of new extension. The thing we should be prepared for, unless we are going to create a completely new extension, is what happens if it is not ready for roll out time. For seperating files, I think by module to start would be easier for now. Once things are moving along we can then think about breaking it down into classes if needed. In the short term will probably make coding faster as there will probably be a lot of cut and paste going on (at least for the function internals). So, would the plan to do a re-write within the domxml extension or make a new extension and then depreciate the old one? Rob ----- Original Message ----- From: "Christian Stocker" <[email protected]> > > Here's my suggestion (and I think, if there are more people than just me > contributing, we should be able to reach this) > > - Go over the whole "memory/free" stuff and clean it up. > > - Seperate php_domxml.c in different files. maybe just the different > modules (xslt/xpath/dom/parser/etc..), or maybe even for each class > (document, node, text, etc) a file (not shure, what's more feasible) > > - use namespaces. Got already a patch from Tal for that. > > - use setters/getters. $domtext->data = "hello" should be possible with > PHP5 (the properties in domxml at the moment are a joke and shouldn't > be used..), this will allow much more dom-compliance > > - Implement first most of the dom-standard. Then we add some of the > convenience methods libxml2 has (get_content() et al. They are not in > the dom-standard, but make the life for domxml-programmers a lot easier > and they are also much faster than using the "traditional" dom methods) > > - Lastly, if there's time, add as much BC as possible. Or we just > provide a PEAR-wrapper, which makes transition from domxml/PHP4.3 to > domxml/PHP5 easier. > > chregu