Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_operators.h php-src configure.in
[email protected] ("Nuno Lopes")
| Newsgroups | php.zend-engine.cvs |
|---|---|
| Message-ID | <0CB7D593C2AE4E46A482AB1C73EC9670@pc07654> |
BTW, would you mind trying it again on that 64-bit machine to check if gcc is still broken there (I found reports about gcc 3.3.x miscompiling memrchr..). Thanks, Nuno ----- Original Message ----- > <tony2001> it's a GNU extension, hence you need a define to make it > available > <tony2001> this define is different everywhere > <tony2001> glibc in SuSE uses __USE_GNU, glibc in Ubuntu uses > __STANDARD_LIB > <nlopes> uhm, my man pages says it's always defined (despite being a GNU > extension) > <tony2001> Also native memchr() didn't work for me on 64bit Linux - it was > returning some garbage pointer instead of valid string > <nlopes> but that's a bug in glibc or gcc.. > <tony2001> nlopes: you know how bugs in glibc are dealt with.. > <nlopes> upgrade it! :) > <tony2001> so currently I see no reasons to use memrchr() as long as we > have zend_memrchr() > > On 13.02.2008 19:30, Antony Dovgal wrote: >> We've already had this fallback and it's been reverted because it didn't >> quite work. >> >> http://cvs.php.net/viewvc.cgi/ZendEngine2/zend_operators.h?r1=1.111&r2=1.112 >> >> On 13.02.2008 19:22, Dmitry Stogov wrote: >>> dmitry Wed Feb 13 16:22:01 2008 UTC >>> >>> Modified files: (Branch: PHP_5_3) >>> /php-src configure.in >>> /ZendEngine2 zend_operators.h >>> Log: >>> Use memrchr() instead of zend_memrchr() if available. (Nuno)