RE: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_2) / zend_builtin_functions.c zend_vm_execute.h

It must be already reverted.
I cought the leak with this code.  :)
Thank you anyway.

Dmitry.

> -----Original Message-----
> From: Hannes Magnusson [mailto:[email protected]] 
> Sent: Tuesday, February 19, 2008 11:46 PM
> To: Dmitry Stogov
> Cc: [email protected]
> Subject: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_2) / 
> zend_builtin_functions.c zend_vm_execute.h
> 
> 
> On Feb 19, 2008 9:45 PM, Hannes Magnusson 
> <[email protected]> wrote:
> > On Feb 19, 2008 5:39 PM, Dmitry Stogov <[email protected]> wrote:
> > > dmitry          Tue Feb 19 16:39:04 2008 UTC
> > >
> > >   Modified files:              (Branch: PHP_5_2)
> > >     /ZendEngine2        zend_builtin_functions.c zend_vm_execute.h
> > >   Log:
> > >   Fixed memory leaks
> > [..]
> > > 
> http://cvs.php.net/viewvc.cgi/ZendEngine2/zend_vm_execute.h?r1=1.62.
> > > 2.30.2.55&r2=1.62.2.30.2.56&diff_format=u
> > > Index: ZendEngine2/zend_vm_execute.h
> > > diff -u ZendEngine2/zend_vm_execute.h:1.62.2.30.2.55 
> ZendEngine2/zend_vm_execute.h:1.62.2.30.2.56
> > > --- ZendEngine2/zend_vm_execute.h:1.62.2.30.2.55        
> Mon Dec 31 07:20:03 2007
> > > +++ ZendEngine2/zend_vm_execute.h       Tue Feb 19 16:39:02 2008
> > > @@ -181,6 +181,13 @@
> > >
> > >                 ALLOC_ZVAL(EX_T(opline->result.u.var).var.ptr);
> > >                 INIT_ZVAL(*(EX_T(opline->result.u.var).var.ptr));
> > > +if (strcmp(EX(function_state).function->common.function_name, 
> > > +"set_error_handler") == 0) { static n = 0;
> > > +++n;
> > > +if (n>=542) {
> > > +fprintf(stderr, "%3d 0x%08X %s\n", n, 
> > > +EX_T(opline->result.u.var).var.ptr, 
> EX(function_state).function->common.function_name);
> > > +}
> > > +}
> >
> > This seems... weird.
> > Was it really intentional?
> >
> 
> Fleh, nevermind. Noticed the latter commit just now :)
> 
> -Hannes
> 
> -- 
> Zend Engine CVS Mailing List (http://cvs.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
> 
>