RE: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / .cvsignore FlexLexer.h Makefile.am Zend.m4 configure.in flex.skl zend.c zend_compile.c zend_compile.h zend_globals.h zend_globals_macros.h zend_highlight.c zend_ini_parser.y zend_ini_scanner.h zend_ini_sca

Hi Marcus,

In general I like more compact scanner, but I see several issues with
your patch.

1) `make install` stops work because of parse error in pear installer

2) Several tests are broken:

  Zend/tests/bug38779.phpt
  ext/standard/tests/file/parse_ini_file.phpt
  ext/standard/tests/strings/006.phpt
  ext/standard/tests/strings/007.phpt
  ext/tokenizer/tests/token_get_all_variation17.phpt

3) I'm wondered why did you remove multibyte support (May be I just
missed the decision on @internals and you are going to reimplement it
after this commit).

4) From my point of view, in case we are going to use re2c, it would be
nice to boundle its sources into PHP source-tree and build system (it is
not a well-known tool).

Thanks. Dmitry.

> -----Original Message-----
> From: Marcus Boerger [mailto:[email protected]] 
> Sent: Monday, March 17, 2008 12:06 AM
> To: [email protected]
> Subject: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / 
> .cvsignore FlexLexer.h Makefile.am Zend.m4 configure.in 
> flex.skl zend.c zend_compile.c zend_compile.h zend_globals.h 
> zend_globals_macros.h zend_highlight.c zend_ini_parser.y 
> zend_ini_scanner.h zend_ini_scanner
> 
> 
> helly		Sun Mar 16 21:05:37 2008 UTC
> 
>   Modified files:              (Branch: PHP_5_3)
>     /ZendEngine2	.cvsignore FlexLexer.h Makefile.am Zend.m4 
>                 	configure.in flex.skl zend.c zend_compile.c 
>                 	zend_compile.h zend_globals.h 
> zend_globals_macros.h 
>                 	zend_highlight.c zend_ini_parser.y 
> zend_ini_scanner.h 
>                 	zend_ini_scanner.l zend_language_scanner.h 
>                 	zend_language_scanner.l zend_stack.c 
> zend_stream.c 
>                 	zend_stream.h zend_strtod.c zend_vm_def.h 
>                 	zend_vm_execute.h 
>     /ZendEngine2/tests	bug42767.phpt 
>   Log:
>   - Rewrite scanner to be based on re2c instead of flex
>     The full patch is available as:
>     http://php.net/~helly/php-re2c-5.3-20080316.diff.txt
>     This is against php-re2c repository version 98
>     An older patch against version 97 is available under:
>     http://php.net/~helly/php-re2c-97-20080316.diff.txt
>   
>   
>