Re: [ZEND-ENGINE-CVS] cvs: TSRM / tsrm_virtual_cwd.c

[email protected] (Rasmus Lerdorf)
Newsgroups php.zend-engine.cvs
Message-ID <[email protected]>
Antony Dovgal wrote:
> On 03/21/2008 06:46 PM, Rasmus Lerdorf wrote:
>>> -		t = CWDG(realpath_cache_ttl)?sapi_get_request_time(TSRMLS_C):0;
>>> +		t = CWDG(realpath_cache_ttl)?time(0):0;
>>>  		if ((bucket = realpath_cache_find(path, path_length, t TSRMLS_CC)) != NULL) {		
>>>  			int len = bucket->realpath_len;
>> Explain please.  This seems like a step backwards.  You are adding a 
>> system call here.
> 
> I did to synchronize this file with 5_3 branch.
> 
> http://cvs.php.net/viewvc.cgi/TSRM/tsrm_virtual_cwd.c?r1=1.74.2.9.2.27&r2=1.74.2.9.2.28
> 
> Fri May 25 22:53:34 2007 UTC (9 months, 3 weeks ago) by rasmus 
> Branch: PHP_5_2 
> Changes since 1.74.2.9.2.27: +2 -3 lines 
> Diff to previous 1.74.2.9.2.27 , to branch point 1.74.2.9 
> Remove simple optimization here for now until we clean up this SAPI/TSRM
> mess.

Hrm..  I need to write better commit messages.  I don't recall what 
SAPI/TSRM mess I was talking about.  Is it simply that we don't want 
TSRM relying on SAPI at all?

-Rasmus
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.