Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_builtin_functions.c
[email protected] (Ilia Alshanetsky)
| Newsgroups | php.zend-engine.cvs |
|---|---|
| Message-ID | <[email protected]> |
Dmitry, Yeah, I think that a good idea, I had some discussion about the functionality with Stas about and I think there are some changes that already need to be made to the patch. I'll make those revisions tonight. On 22-Oct-08, at 3:31 AM, Dmitry Stogov wrote: > Hi Ilia, > > I think it would be good to wrap the patch with #ifdef 0 while we > don't > have decision about namespaces. > > Thanks. Dmitry. > > Ilia Alshanetsky wrote: >> Unless separator for namespaces changes as per discussion on >> internals, >> if not the patch will need to be reverted. >> >> >> On 20-Oct-08, at 5:21 AM, Antony Dovgal wrote: >> >>> On 19.10.2008 22:07, Ilia Alshanetsky wrote: >>>> iliaa Sun Oct 19 18:07:37 2008 UTC >>>> >>>> Modified files: (Branch: PHP_5_3) >>>> /ZendEngine2 zend_builtin_functions.c >>>> Log: >>>> Fixed bug #46341 (Added missing validation checks into define() for >>>> class >>>> constants) >>> >>> This breaks Zend/tests/ns_053.phpt. >>> >>> -- >>> Wbr, >>> Antony Dovgal >>> >>> -- >>> Zend Engine CVS Mailing List (http://cvs.php.net/) >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >> >> Ilia Alshanetsky >> >> >> >> >> Ilia Alshanetsky