Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 /tests bug46196.phpt

Hello Jani,

  nope. This gives well deserved credits to people that spend work on
testing which is not always easy. And since many of us core developers
do not test we rely on those people and need to make sure it gets
attractive to write tests. And how the keck do you think a credit line
disturbs any of your test experiences?

marcus

Monday, November 3, 2008, 1:04:56 PM, you wrote:

> Felix De Vliegher wrote:
>> felixdv               Sun Nov  2 20:15:16 2008 UTC
>> 
>>   Added files:                 
>>     /ZendEngine2/tests        bug46196.phpt 
>>   Log:
>>   XFAIL test for bug #46196 on restore_error_handler().
>>   
>>   
>> 
>> http://cvs.php.net/viewvc.cgi/ZendEngine2/tests/bug46196.phpt?view=markup&rev=1.1
>> Index: ZendEngine2/tests/bug46196.phpt
>> +++ ZendEngine2/tests/bug46196.phpt
>> --TEST--
>> Test restore_error_handler() function : bug #46196
>> --CREDITS--
>> Olivier Doucet

> WTF? Credits for tests? Come on..these are already bloated with shit 
> like XFAIL and such..

> --Jani



>> --XFAIL--
>> This test will fail until bug #46196 is fixed
>> --FILE--
>> <?php
>> /* Prototype  : void restore_error_handler(void)
>>  * Description: Restores the previously defined error handler function 
>>  * Source code: Zend/zend_builtin_functions.c
>>  * Alias to functions: 
>>  */
>> 
>> echo "*** Testing restore_error_handler() : error bug #46196 ***\n";
>> 
>> var_dump( set_error_handler( 'myErrorHandler' ) );
>> var_dump( restore_error_handler() );
>> var_dump( set_error_handler( 'myErrorHandler' ) );
>> 
>> function myErrorHandler($errno, $errstr, $errfile, $errline)
>> {
>>     return true;
>> }
>> 
>> ?>
>> ===DONE===
>> --EXPECTF--
>> *** Testing restore_error_handler() : error bug #46196 ***
>> NULL
>> bool(true)
>> NULL
>> ===DONE===
>> 
>> 
>> 





Best regards,
 Marcus