Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_float.h

Hi Pierre,

Christian is going to fix it, so there is no reason to make quick hacks.

Thanks. Dmitry.

Pierre-Alain Joye wrote:
> pajoye		Tue Mar 17 13:33:51 2009 UTC
> 
>   Modified files:              
>     /ZendEngine2	zend_float.h 
>   Log:
>   - disable HAVE__CONTROLFP_S with VC9, 3x times slowdown
>   
> http://cvs.php.net/viewvc.cgi/ZendEngine2/zend_float.h?r1=1.3&r2=1.4&diff_format=u
> Index: ZendEngine2/zend_float.h
> diff -u ZendEngine2/zend_float.h:1.3 ZendEngine2/zend_float.h:1.4
> --- ZendEngine2/zend_float.h:1.3	Fri Jan  2 20:36:30 2009
> +++ ZendEngine2/zend_float.h	Tue Mar 17 13:33:51 2009
> @@ -16,7 +16,7 @@
>     +----------------------------------------------------------------------+
>  */
>  
> -/* $Id: zend_float.h,v 1.3 2009/01/02 20:36:30 felipe Exp $ */
> +/* $Id: zend_float.h,v 1.4 2009/03/17 13:33:51 pajoye Exp $ */
>  
>  #ifndef ZEND_FLOAT_H
>  #define ZEND_FLOAT_H
> @@ -69,8 +69,11 @@
>  /* MSVC detection (MSVC people usually don't use autoconf) */
>  #ifdef _MSC_VER
>  # if _MSC_VER >= 1500
> +   /* Disable it, it slowdowns the floating operation more than
> +      anything else, by a factor 3 (using Bench.php (mandel and 
> +      mandel2 for example)*/
>     /* Visual C++ 2008 or higher, supports _controlfp_s */
> -#  define HAVE__CONTROLFP_S
> +   /*#  define HAVE__CONTROLFP_S */
>  # else
>     /* Visual C++ (up to 2005), supports _controlfp */
>  #  define HAVE__CONTROLFP
> 
> 
>